Simplify automatic provisioning code #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of setting an environment variable to affect the behaviour of Kolibri's initialize() function, we will call provision_from_file() directly. This makes the application's initial setup process easier to predict, and allows us to avoid creating unnecessary files.
dbnicholson
approved these changes
Sep 15, 2023
There was a problem hiding this comment.
I like it. I was going to say it should go before initialize, but I guess that all needs to be run first before you can attempt to provision the device. The other thing I was thinking about was that an automatic provision file may already be configured (either from an environment variable or in options.ini), but I don't see why we shouldn't allow that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of setting an environment variable to affect the behaviour of Kolibri's initialize() function, we will call provision_from_file() directly. This makes the application's initial setup process easier to predict, and allows us to avoid creating unnecessary files.