Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebrand loading page for Endless Key #44

Closed
wants to merge 3 commits into from

Conversation

GeorgesStavracas
Copy link
Contributor

See first and second commit. The last commit is merely a reproduction of what translation changes would look like.

I'd like to get some feedback here first, before applying this change to all files.

A nice follow-up improvement where we inject a loading page might be feasible since learningequality/kolibri-app#110 has been merged. I haven't looked at it yet.

Switch to the one that kolibri-explore-plugin uses.
Add a grid-like div with the Endless Key logo as content,
and the "Powered by Kolibri" icon as a footer.
@GeorgesStavracas
Copy link
Contributor Author

This is how it looks right now:

Gravacao.de.tela.de.2023-09-12.15-34-13.webm

The error screen:

image

(I did not change error strings!)

@dylanmccall
Copy link
Contributor

dylanmccall commented Sep 12, 2023

That seems fine for the moment, at least so we have a nice consistent-looking experience to start with. I think it would be okay to drop the localized versions for now so we don't have to deal with those. We can add a follow-up task to switch to something like what learningequality/kolibri-app is doing now, or the same thing we're doing in endlessm/kolibri-installer-android (but it would be nice if that was also doing the shiny new thing from kolibri-app).

@dbnicholson
Copy link
Member

I think this all goes away after #72 and any further improvements should be made in the loading-screen package in kolibri-explore-plugin.

@dylanmccall
Copy link
Contributor

Yep, we can close this. With that said, I kind of want to get the Explore plugin to do a normal template override for the loading screen, and this branch could be a useful reference for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants