Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix validation tests #36

Merged
merged 2 commits into from
Sep 9, 2023
Merged

Fix validation tests #36

merged 2 commits into from
Sep 9, 2023

Conversation

dylanmccall
Copy link
Contributor

This fixes an issue that appeared after #35 (coupled with #33), and another minor issue that I noticed while fixing it :)

@dylanmccall
Fix desktop ID capitalization in validation test
e1c0a5b 
The string "endless" was changed to "Endless" in a separate commit.
Either one is rejected by appstreamcli.
@dylanmccall
Set workdir for desktop and metainfo validation tests
c0e0338 
Previously, these tests were failing in GNOME Builder 44 due to the
tests running from the wrong path.
@dylanmccall
Copy link
Contributor Author

dylanmccall commented Sep 8, 2023 •
edited
Loading

This fixes an issue that broke the build in #9. The same issue isn't appearing in the main branch because the test is being skipped there: appstreamcli (switched to in #33) is not available in the org.gnome.Sdk//44 runtime, but it will be in the next release (currently org.gnome.Sdk//master).

dbnicholson
dbnicholson approved these changes Sep 9, 2023
View reviewed changes
Copy link
Member

@dbnicholson dbnicholson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Hmmm, I wonder if there's an easy way to cram appstreamcli into the flatpak build.

@dbnicholson dbnicholson merged commit 009cb68 into main Sep 9, 2023
2 checks passed
@dbnicholson dbnicholson deleted the fix-validation-tests branch September 9, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbnicholson dbnicholson dbnicholson approved these changes

@pwithnall pwithnall Awaiting requested review from pwithnall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylanmccall @dbnicholson