Rebase 2.3.3 #19
Merged
Rebase 2.3.3 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of these options always using a `KOLIBRI_APP_` or `KOLIBRI_DEVEL_APP_` prefix based on the build profile, we will generate a prefix at build time. This will allow different build configurations to use different prefixes without needing to modify Python code.
Improve app environment variable prefixes
`Gdk` is no longer used and python statements don't require semicolons.
This makes sure the linting is run for pull requests and builds the flatpak as a bundle. That will make testing much easier prior to its existence on Flathub.
In `KolibriDaemonManager.__kolibri_api_call_async`, we were incorrectly calling `Soup.Message.set_request_body`. This function no longer exists in Soup 3.0. Instead, we should use `set_request_body_from_bytes`. learningequality/kolibri-installer-gnome#92
Make the development flatpak build as org.endlessos.Key.Devel.
Including modification
- ("Add github workflow to lint and build flatpak bundle")
from Dan Nicholson
Fixes: #7
dylanmccall
force-pushed
the
rebase-2.3.3
branch
from
5e370b6
to
99c8a72
Compare
dbnicholson
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18