Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[perf] hashing function improvements #3242

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 41 additions & 34 deletions packages/hash/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,62 +2,69 @@
// Inspired by https://github.com/garycourt/murmurhash-js
// Ported from https://github.com/aappleby/smhasher/blob/61a0530f28277f2e850bfc39600ce61d02b518de/src/MurmurHash2.cpp#L37-L86

const encoder = new TextEncoder()
romgrk marked this conversation as resolved.
Show resolved Hide resolved

// bufferLength must be a multiple of 4 to satisfy Int32Array constraints
let bufferLength = 2 * 1024
let buffer = new ArrayBuffer(bufferLength)
let uint8View = new Uint8Array(buffer)
let int32View = new Int32Array(buffer)
romgrk marked this conversation as resolved.
Show resolved Hide resolved

export default function murmur2(str: string): string {
if (str.length > bufferLength) {
// buffer.resize() is only available in recent browsers, so we re-allocate
// a new buffer and views
bufferLength = str.length + (4 - str.length % 4)
buffer = new ArrayBuffer(bufferLength)

uint8View = new Uint8Array(buffer)
int32View = new Int32Array(buffer)
}

const length = encoder.encodeInto(str, uint8View).written;

// 'm' and 'r' are mixing constants generated offline.
// They're not really 'magic', they just happen to work well.

// const m = 0x5bd1e995;
// const r = 24;
const m = 0x5bd1e995;
const r = 24;
romgrk marked this conversation as resolved.
Show resolved Hide resolved

// Initialize the hash

var h = 0
let h = 0

// Mix 4 bytes at a time into the hash

var k,
i = 0,
len = str.length
for (; len >= 4; ++i, len -= 4) {
k =
(str.charCodeAt(i) & 0xff) |
((str.charCodeAt(++i) & 0xff) << 8) |
((str.charCodeAt(++i) & 0xff) << 16) |
((str.charCodeAt(++i) & 0xff) << 24)

k =
/* Math.imul(k, m): */
(k & 0xffff) * 0x5bd1e995 + (((k >>> 16) * 0xe995) << 16)
k ^= /* k >>> r: */ k >>> 24

h =
/* Math.imul(k, m): */
((k & 0xffff) * 0x5bd1e995 + (((k >>> 16) * 0xe995) << 16)) ^
/* Math.imul(h, m): */
((h & 0xffff) * 0x5bd1e995 + (((h >>> 16) * 0xe995) << 16))
let i = 0
let len = length
for (; len >= 4; i++, len -= 4) {
let k = int32View[i]

k = Math.imul(k, m)
romgrk marked this conversation as resolved.
Show resolved Hide resolved
k ^= k >>> r
k = Math.imul(k, m)

h = Math.imul(h, m)
h ^= k
}

// Handle the last few bytes of the input array

switch (len) {
case 3:
h ^= (str.charCodeAt(i + 2) & 0xff) << 16
h ^= (uint8View[i * 4 + 2] & 0xff) << 16
case 2:
h ^= (str.charCodeAt(i + 1) & 0xff) << 8
h ^= (uint8View[i * 4 + 1] & 0xff) << 8
case 1:
h ^= str.charCodeAt(i) & 0xff
h =
/* Math.imul(h, m): */
(h & 0xffff) * 0x5bd1e995 + (((h >>> 16) * 0xe995) << 16)
h ^= uint8View[i * 4] & 0xff
h = Math.imul(h, m)
}

// Do a few final mixes of the hash to ensure the last few
// bytes are well-incorporated.

h ^= h >>> 13
h =
/* Math.imul(h, m): */
(h & 0xffff) * 0x5bd1e995 + (((h >>> 16) * 0xe995) << 16)
h = Math.imul(h, m)
h = (h ^ (h >>> 15)) >>> 0

return ((h ^ (h >>> 15)) >>> 0).toString(36)
return h.toString(36)
}
Loading