Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jest serialization issue (#2642) #2959

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeremy-davis-sonarsource
Copy link

@jeremy-davis-sonarsource jeremy-davis-sonarsource commented Dec 21, 2022

What: fix #2642

Checklist:

  • Documentation N/A
  • Tests
  • Code complete
  • Changeset

@changeset-bot
Copy link

changeset-bot bot commented Dec 21, 2022

🦋 Changeset detected

Latest commit: 09472c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@emotion/jest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 21, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@jeremy-davis-sonarsource jeremy-davis-sonarsource changed the title Test case that breaks the cleanup of empty classname Fix jest serialization issue (#2642) Jan 6, 2023
@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.08%. Comparing base (6e0e388) to head (0b695c2).

Additional details and impacted files
Files Coverage Δ
packages/jest/src/create-serializer.js 100.00% <100.00%> (ø)

@shannonhochkins
Copy link

shannonhochkins commented Dec 18, 2023

Why isn't this merged? - i have the same issue and this code will fix it for me as well, @jeremy-davis-sonarsource did you ever find another solution for this?

@jeremy-davis-sonarsource
Copy link
Author

Why isn't this merged? - i have the same issue and this code will fix it for me as well, @jeremy-davis-sonarsource did you ever find another solution for this?

We simply got rid of the empty classname props. Fortunately, there weren't too many of them (2~3).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PrettyFormatPluginError: Cannot delete property 'className' of #<Object>
2 participants