Hold GIL for drops on futures cancellation (#350)

emmett-framework · Jul 9, 2024 · 24db55e · 24db55e
1 parent 1749141
commit 24db55e
Showing 1 changed file with 13 additions and 2 deletions.
diff --git a/src/runtime.rs b/src/runtime.rs
@@ -204,7 +204,11 @@ where
                     Python::with_gil(|_| drop(aw));
                 });
             },
-            () = cancel_tx.notified() => {}
+            () = cancel_tx.notified() => {
+                let _ = rb.run(move || {
+                    Python::with_gil(|_| drop(aw));
+                });
+            }
         }
     });
 
@@ -249,7 +253,14 @@ where
                     });
                 });
             },
-            () = cancel_tx.notified() => {}
+            () = cancel_tx.notified() => {
+                let _ = rb.run(move || {
+                    Python::with_gil(|py| {
+                        drop(fut_ref);
+                        drop(event_loop_ref);
+                    });
+                });
+            }
         }
     });