Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin support for translations #902

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Feb 20, 2022

Implementation prompted by: #901

This will enable users:

  • to switch to their preferred language
  • help translate to their preferred language
  • not need to worry about the technical details of how to setup ember-intl

Non-goals:

  • actually do translations for non-english (PRs very welcome for that)

Open for discussion:

  • keep everything in git? or lean on something like CrowdIn? (or other translation service?)
    • I think CrowdIn has an embeddable widget to allow folks to translate without interacting with code
      • I can set this up and own it if folks want to see how it works / a demo, etc

Remaining Requirements:

  • need to lessen the barrier to contribution / translation submission (potentially via in-site widget)
  • need to have a way to display when translations are out of date on a specific page (most useful for the guides)
  • need to polish up the language switcher

Developing:

  • locally, there will be "missing translation" errors", but in production a fallback of english is configured

Notes on the PR:

  • translation switcher needs work, what is in this PR is the bare minimum to demonstrate the functionality
  • sample translations are from google translate, so, we'll see if native speakers agree with a machine or not 🙃 (not required for merging, but just demonstration in this PR)

@netlify
Copy link

netlify bot commented Feb 20, 2022

✔️ Deploy Preview for ember-website ready!

🔨 Explore the source changes: 07b3bcc

🔍 Inspect the deploy log: https://app.netlify.com/sites/ember-website/deploys/621272c5038f360008017dcc

😎 Browse the preview: https://deploy-preview-902--ember-website.netlify.app


<ul class="list-unstyled">
<li><a href="https://emberweekend.com/episodes">Ember Weekend</a></li>
<li><a href="https://embermap.com/podcast">Ember Map Podcast</a></li>
{{t "index.learning.podcasts.list" htmlSafe=true}}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By putting the whole list in a translation, different languages can either

  • swap these with links to the same resources in a different language (maybe that's supported via query params or something),
  • add language-specific resources
  • replace all the links entirely

@@ -26,6 +26,9 @@
"start": "ember serve",
"test": "ember test"
},
"overrides": {
"ember-cli-babel": "^7.26.11"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added this because the console warnings about a bunch of different ember-cli-babel versions kinda make this app look unmaitained 😅

@@ -108,6 +112,7 @@
"algoliasearch"
],
"volta": {
"node": "14.16.0"
"node": "14.16.0",
"npm": "8.5.1"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm 8+ required for overrides

@stale
Copy link

stale bot commented Jun 12, 2022

This pull request has been automatically marked stale. If this pull request is something that still needs work, please add a comment and it will remain open, otherwise it will close in 7 days. You are welcome to open a new pull request if you miss the window. Thanks!

@stale stale bot added the stale label Jun 12, 2022
@NullVoxPopuli
Copy link
Contributor Author

stalebot is hostile to long-running work. shoo. lol

@stale stale bot removed the stale label Jun 12, 2022
@stale
Copy link

stale bot commented Aug 13, 2022

This pull request has been automatically marked stale. If this pull request is something that still needs work, please add a comment and it will remain open, otherwise it will close in 7 days. You are welcome to open a new pull request if you miss the window. Thanks!

@stale stale bot added the stale label Aug 13, 2022
@NullVoxPopuli
Copy link
Contributor Author

Rude, bot

@stale stale bot removed the stale label Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant