Generalize citar--shorten-names + add display transform function for full names

[torfjelde]

Generalizes citar--shorten-names + implements rendering of full names as discussed in #805.

Replaces #807 as I did not follow the contribution guidelines in #807.

[torfjelde]

@bdarcus are there any tests for this stuff? Didn't see anything obvious from a quick glance.

[bdarcus]

are there any tests for this stuff?

Do you mean in this project, or more generally?

If the former, this is an example (see #780) where we should probably add some.

[torfjelde]

For the project, and specifically of the display transform functions:)

But aight; should I just make a new ert-deftest for the short- and full-name methods? Are there an existing list of author names that I could maybe draw from as test-cases, or should I add some?

[bdarcus]

Are there an existing list of author names that I could maybe draw from as test-cases, or should I add some?

There isn't, but I can give you an example of a key type that I included when developing the existing function; a corporate (organizational) name:

World Bank

That shouldn't be shortened.

Now that I think about it, you should be aware of the discussion here, in part because OP has some test names, but also because it's about refactoring that function:

#532

[bdarcus]

So what do we want to do with this, given @aikrahguzar's alternative?

#805 (comment)

[bdarcus]

So what do we want to do with this, given @aikrahguzar's alternative?

#805 (comment)

I'm going to close this, and we can consider @aikrahguzar's alernative.