Feature/reinstate #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the moment the post was created to make any changes. After that, the edit is not allowed. Moderators can always edit regardless of this time constraint.
…ds compatible wherever possible.
Accounting for modules deprecated in Django 1.6
…e to check for comment flooding
| @@ -17,6 +19,10 @@ | |||
|
|
|||
| redis = Redis(**comments_settings.REDIS) | |||
|
|
|||
| EDIT_TIMER_ENABLED = getattr(settings, 'EDIT_TIMER_ENABLED', False) | |||
There was a problem hiding this comment.
please use comment_settings for these values as well.
|
I added some comments to the code, please also include tests thanks |
|
I'll make the changes. Bizarrely some of the edit_timer methods are already in master from a previous (Before my time) merge. I'm not sure why're they are showing up in this diff but I can implement the above recommendations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys,
I had to make a small change to the ella flatcomments branch to improve spam filtering / handling. They include adding a reinstate method to re-post comments that have been removed, and adding a submit date to unsaved comments, so that these comments can be compared to previous comments to detect flooding