feat: show relationship badge and remove hover-only label on follow button #2397
Conversation
|
|
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…over-only label on follow button
shuuji3
force-pushed
the
a11y/show-relationship-badge
branch
from
493d1c7
to
d9fa908
Compare
|
Why not putting the relationship badge aside the username? |
|
@edimitchel Because I felt a bit crowded when the account had many badges or the name was long, also it can mimic the other platform. But maybe it was not necessary, and better to place the same position as other badges for consistency. Let me adjust the position. |
|
Yes, it was not as bad as I thought. 
|
| import type { mastodon } from 'masto' | ||
|
|
||
| defineProps<{ | ||
| relationship?: mastodon.v1.Relationship |
There was a problem hiding this comment.
IMO this shouldn't be optional and rather the v-if should be applied outside of this component
There was a problem hiding this comment.
Thanks for your review. That makes sense. I changed it to be non-optional.
|
To preview the PR, you can visit, for example, https://deploy-preview-2397--elk-zone.netlify.app/universeodon.com/@[email protected] to see "Mutuals" badge. |
resolve #1020
This PR implements two changes:
Examples
When the account follows you but you don't follow them:
When the account follows you and you follow them:
