Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix up some module paths #41

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jvkersch
Copy link

@jvkersch jvkersch commented Sep 21, 2024

To get the tests to run (doctests and integration tests) I had to update two module imports.

Summary by Sourcery

Fix module import paths in the TES client to resolve issues with running doctests and integration tests.

Bug Fixes:

  • Correct module import paths from 'model' to 'models' in the TES client to ensure tests run successfully.

Copy link
Contributor

sourcery-ai bot commented Sep 21, 2024

Reviewer's Guide by Sourcery

This pull request updates module import paths in two files to fix test execution issues. The changes are minor but important for the correct functioning of doctests and integration tests.

File-Level Changes

Change Details Files
Update import path for ListTasksParams
  • Change import path from 'ga4gh_sdk::clients::tes::model::ListTasksParams' to 'ga4gh_sdk::clients::tes::models::ListTasksParams'
lib/src/clients/tes/mod.rs
lib/tests/funnel_tes.rs

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jvkersch - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant