Live update unread mail badge for INBOX #722
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Merged
|
Hm, so from what I can tell this only removes the badges from special folders, not user-created folders. I'm kind of on the fence about this anyways. I'm not sure if having no information is better than having old information. Thoughts @elementary/ux? |
|
Alright; lets tackle this on 7 then. IIRC the update event was not fired for other folders which might be a bug in EDS solved in a newer version 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds live update of the unread mail badge count for INBOX folders.
For whatever reason the
folder_changedsignal is not emitted for all other folders on my end. As I don't see a possibility to update their unread mail badge, I made sure they are hidden.Partly f*xes #659