Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus window when it demands attention #2041

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Focus window when it demands attention #2041

merged 1 commit into from
Aug 21, 2024

Conversation

lenemter
Copy link
Member

Fixes #1052

@lenemter lenemter requested a review from a team August 21, 2024 06:41
leolost2605
leolost2605 approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I guess we could do these few lines of code also in WindowManager although I get that you want to avoid making it bigger than it already is so u decide :)

@danirabbit danirabbit merged commit c3d894a into main Aug 21, 2024
2 of 4 checks passed
@danirabbit danirabbit deleted the lenemter/focus-window-when-it-demands-attention branch August 21, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leolost2605 leolost2605 leolost2605 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workspace doesn't switch automatically when invoke app from different workspace
3 participants
@lenemter @leolost2605 @danirabbit