Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental SSS #36

Draft
wants to merge 12 commits into
base: develop
Choose a base branch
from
Draft

Experimental SSS #36

wants to merge 12 commits into from

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Sep 12, 2024

Working branch to get SSS functional on element-web.

Requires matrix-org/matrix-js-sdk#4400

Current status is that it syncs, but the room lists don't load until the next sync request, so take 30s to appear. This is because element web doesn't add the requests for the lists until after sliding sync has started, and SSS doesn't support txn_id which the SS impl uses to track requests for cancellation (it looks like previously it would have started the second request and the shortly after, canceled it and made a new one with the room lists).

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Working branch to get SSS functional on element-web.

Requires matrix-org/matrix-js-sdk#4400
@CLAassistant
Copy link

CLAassistant commented Sep 13, 2024

CLA assistant check
All committers have signed the CLA.

@kegsay kegsay added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Sep 13, 2024
This is actually required for SSS because otherwise it would use
the proxy over native support.
- Update the spidering code to spider all the relevant lists.
- Add canonical alias to the required_state to allow room name calcs to work.

Room sort order is busted because we don't yet look at `bump_stamp`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants