Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the CallScreen into the safe area and let ElementCall handle layout #3210

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu added the pr-misc for other changes label Aug 29, 2024
@stefanceriu stefanceriu requested a review from a team as a code owner August 29, 2024 07:06
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team August 29, 2024 07:06
Copy link

github-actions bot commented Aug 29, 2024

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 1f4e94d

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.51%. Comparing base (e439689) to head (1f4e94d).
Report is 26 commits behind head on develop.

Files with missing lines Patch % Lines
...X/Sources/Screens/CallScreen/View/CallScreen.swift 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3210      +/-   ##
===========================================
+ Coverage    77.50%   77.51%   +0.01%     
===========================================
  Files          722      722              
  Lines        57218    57242      +24     
===========================================
+ Hits         44345    44372      +27     
+ Misses       12873    12870       -3     
Flag Coverage Δ
unittests 68.29% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu marked this pull request as draft August 29, 2024 09:10
Copy link

sonarcloud bot commented Aug 29, 2024

@pixlwave pixlwave removed their request for review August 29, 2024 11:24
@CLAassistant
Copy link

CLAassistant commented Sep 6, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants