Celery / Background processing support for django-sendgrid-events #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated to use process the sendgrid events on celery if the settings variable SENDGRID_BACKGROUND_PROCESSING is set to True
#1006 - Support Celery Tasks
|
I don't mind this at all, but don't want to require dependency on |
#1211 sendgrid Events not JSON serializable for celery
|
@paltman Our developer Abel implemented the hookset refactor you were talking about and I added some instructions in the README about how to configure Celery support in your project. Thoughts? |
added new column to show post_office.models.Email related object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Patrick, we've been using django-sendgrid-events on https://www.tribute.co with good success. One thing we recently added in our fork was a quick check for some settings vars to enable background processing via celery workers. We use Heroku, so it frees up our web dynos for quicker request/response cycles and performs the work on a background worker. Anyways, here's a PR if you're interested : )