Also support version on go install #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barkbay
reviewed
Jul 25, 2024
thbkrkr
force-pushed
the
support-version-go-install
branch
from
7ad167d
to
a7eeb94
Compare
|
Testing:
> go install .
/u/k/d/s/g/e/crd-ref-docs support-version-go-install * krkr@fun
> crd-ref-docs -v
Version: (devel)
GitCommit: b78ab371d7dc70c27133eb266576f7021166eb5a
BuildDate: 2024-07-25T10:52:35Z
> go install github.com/elastic/[email protected]
go: downloading github.com/elastic/crd-ref-docs v0.0.13-bc6
> crd-ref-docs -v
Version: v0.0.13-bc6
GitCommit: (unknown)
BuildDate: (unknown)Downloading released binary. > wget https://github.com/elastic/crd-ref-docs/releases/download/v0.0.13-bc6/crd-ref-docs_0.0.13-bc6_Darwin_arm64.tar.gz
> tar xvzf crd-ref-docs_0.0.13-bc6_Darwin_arm64.tar.gz
> ./crd-ref-docs -v
Version: v0.0.13-bc6
GitCommit: b78ab37
BuildDate: 2024-07-25T10:53:42Z |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
versioncommand also works when the binary is installed usinggo install.Follow-up of #78 and #84.