Replace crypto #22
Merged
Replace crypto #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
einarmo
force-pushed
the
replace-crypto
branch
from
6db2759
to
4d7ae95
Compare
einarmo
force-pushed
the
replace-crypto
branch
from
4d7ae95
to
a960909
Compare
einarmo
force-pushed
the
replace-crypto
branch
from
677f80c
to
da155b0
Compare
|
For reference, this is tested against the OPC Foundation reference SDK, to ensure that the cryptography is properly implemented. Adding automated tests doing something like that is still a TODO... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you're notified about this PR, bs1959, I'm working ahead on a rewrite of pretty much the whole library, and your openssl change was quite nice. This is mostly your work, with some resolved merge conflicts, clippy lints, and some perf improvements in tests.