Fix unknown entity type with multilingual #497
Conversation
|
Based on code review, seems good to me (correct way to handle multi-lingual). However, I don't have a site to test it on. |
civicrm_entity.module
Outdated
| // @codingStandardsIgnoreStart | ||
| global $dbLocale; | ||
| // @codingStandardsIgnoreEnd | ||
| $locales = \CRM_Core_I18n::getMultilingual(); |
There was a problem hiding this comment.
@herbdool @jackrabbithanna the changes in this file I don't think should being done
In the Supported Entities I think that makes sense as we need an entity for each locale
However in this function I think we are modifying the views query about to be executed so I would have thought we want to only use the active locale rather than all locales because i think the effect of the change in L671-L673 would mean that the last local in the list would be used rather than the active one.
E.g. if you had a list of enabled locales in CiviCRM like en_US,fr_FR,pt_PT or something and you viewed the French version of the view page (based on the url i.e. having /fr/) I think with the changes made in L671-673 and L684-686 this would mean you would only ever get the Portaguese version and also possibly you would get the completely wrong field name as well because it would seem to me that you might end up with a string like title_pt_PT_fr_FR_en_US which doesn't exist in the db as well
There was a problem hiding this comment.
That makes sense to me. I'll remove the changes in this file.
Fixes https://www.drupal.org/project/civicrm_entity/issues/3467704