Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metatag not loading. #481

Merged
merged 3 commits into from
May 21, 2024

Conversation

puresyntax71
Copy link
Contributor

Overview

When metatag ^2 module is installed, visiting a CE page e.g. /civicrm-contact/1 throws this error:

Error: Call to a member function getDefaults() on null in civicrm_metatags_alter() (line 404 of modules/contrib/civicrm/civicrm.module).

Before

Throws an error.

After

No more error.

@civibot civibot bot added the 4.0.x label May 10, 2024
@puresyntax71 puresyntax71 marked this pull request as ready for review May 21, 2024 16:56
@jackrabbithanna
Copy link
Collaborator

I'm merging this, so CE can be used with Metatag 2.0 in the next release

@jackrabbithanna jackrabbithanna merged commit fa0bd3c into eileenmcnaughton:4.0.x May 21, 2024
2 checks passed
puresyntax71 added a commit to puresyntax71/civicrm_entity that referenced this pull request Aug 22, 2024
* upstream/4.0.x:
  Support for basefield overrides (eileenmcnaughton#496)
  update tests, 10.3 official, and 5.75 (eileenmcnaughton#490)
  check for metatag_computed field, for Drupal entity based saves with Metatag 2.0 (eileenmcnaughton#489)
  use LoggerChannelFactoryInterface instead of default service (eileenmcnaughton#488)
  update tests for 10.3 and 11 (eileenmcnaughton#484)
  fix edge case updating base field definition for bundles (eileenmcnaughton#487)
  Add patch from https://www.drupal.org/project/civicrm_entity/issues/3447309. (eileenmcnaughton#486)
  Fix metatag not loading. (eileenmcnaughton#481)
  update settings form for D11 compatibility (eileenmcnaughton#485)
  adding logger parameter to ModulerInstaller service (eileenmcnaughton#483)
  update composer.json for Drupal 11 (eileenmcnaughton#482)
  deprecation fixes for D11 (eileenmcnaughton#480)
  Adds Checksum validation solution for Drupal Views (eileenmcnaughton#478)
  Add pcp. (eileenmcnaughton#477)
  supportedentities update AllCoreTables function (eileenmcnaughton#479)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants