supportedentities update AllCoreTables function #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at the Core AllCoreTables commit history, this code has been in place for basically 8yrs. I do not think this change will effect anyone that uses any reasonably modern version of CiviCRM. To use 4.0.x branch with D10 users would have to have 5.60 or greater. |
puresyntax71
added a commit
to puresyntax71/civicrm_entity
that referenced
this pull request
Aug 22, 2024
* upstream/4.0.x: Support for basefield overrides (eileenmcnaughton#496) update tests, 10.3 official, and 5.75 (eileenmcnaughton#490) check for metatag_computed field, for Drupal entity based saves with Metatag 2.0 (eileenmcnaughton#489) use LoggerChannelFactoryInterface instead of default service (eileenmcnaughton#488) update tests for 10.3 and 11 (eileenmcnaughton#484) fix edge case updating base field definition for bundles (eileenmcnaughton#487) Add patch from https://www.drupal.org/project/civicrm_entity/issues/3447309. (eileenmcnaughton#486) Fix metatag not loading. (eileenmcnaughton#481) update settings form for D11 compatibility (eileenmcnaughton#485) adding logger parameter to ModulerInstaller service (eileenmcnaughton#483) update composer.json for Drupal 11 (eileenmcnaughton#482) deprecation fixes for D11 (eileenmcnaughton#480) Adds Checksum validation solution for Drupal Views (eileenmcnaughton#478) Add pcp. (eileenmcnaughton#477) supportedentities update AllCoreTables function (eileenmcnaughton#479)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://www.drupal.org/project/civicrm_entity/issues/3444138
Problem/Motivation
Many message
Deprecated function CRM_Core_DAO_AllCoreTables::getCoreTables, use CRM_Core_DAO_AllCoreTables::tables. CRM_Core_Error::deprecatedFunctionWarning CRM_Core_DAO_AllCoreTables::getCoreTables Drupal\civicrm_entity\SupportedEntities::getEntityTypeDaoClass Drupal\civicrm_entity\CivicrmEntityViewsData::getViewsFilterPlugin Array ( [civi.tag] => deprecated )
Proposed resolution
In SupporteddEntities class, method getEntityTypeDaoClass, call \CRM_Core_DAO_AllCoreTables::tables(); instead of \CRM_Core_DAO_AllCoreTables::getCoreTables();
Other notes
Function was deprecated in 5.72
Only thing to be sure of here is will this change break functionality in older versions of CiviCRM.