Fix column name for grouping custom fields in Views #442
+69
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay looks like legitimate errors after I fixed my typos. Will look at it today |
|
I had left this PR in one of my locals. I observed that with this PR, adding a Civi custom field, that is in a Civi custom field group allowing multiple values, breaks the View. I see errors like: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes the column Views uses for grouping custom fields. It was defaulting to
value, the default column name for fields.Technical Details
Provides a wrapped base field definition class to always return proper column names for custom fields. Modifies a View plugin method which replaces the field definition class.
Comments
Anything else you would like the reviewer to note
Release notes snippet
The notes to be added on the release