Fix incorrect columns on custom fields #441
Open
+69
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Matt right on. If you don't mind can you make a PR for the 4.0.x branch first? Made a D10 version there, and 3.x will go unsupported sometime after D9 EOL. Wanting to make sure anything that gets into 3.x gets into 4.0.x. I can put it there though win this is finished if not. Thanks! |
|
Oh I didn't even notice. I just started hacking with my local branch. I'll revise |
|
4.x PR #442 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Views is pulling wrong columns name for Group By in Views
Before
Issue in https://civicrm.stackexchange.com/questions/45192/getting-aggregation-to-work-in-d9-d10-views-with-civicrm-relationships
After
GROUP BY added for custom field
Technical Details
Drupal defaults the column to
valuewhich isn't true for custom field tables.Comments
Anything else you would like the reviewer to note
Release notes snippet
The notes to be added on the release