fix: add support for windows hosts #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkillerud
force-pushed
the
win
branch
2 times, most recently
from
77ac731
to
22e9ade
Compare
|
Had hoped the refactor of the tests would fix the ECONNRESET on Windows, but alas. I'll put a pin in this until I'm on my Windows rig. |
|
The error only happens on Node 18 on Windows. |
The sink is what we need to reset most of the times. This is an attempt to make the test suite faster and more stable on macOS.
The tests all spin up their own service instance, this should be fine.
We're the only ones using it
For an unknown reason the upload tests fail on Node 18 on Windows with an ECONNRESET from node-fetch. Debugging hasn't revealed any probable cause. - The fixture readable stream works as expected on Node 18 on Windows - Other requests to the server work as expected Refactoring to use native fetch means we lose the option to override the origin hostname, which we use to test server validation.
|
🎉 This issue has been resolved in version 2.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: