fix: include type definitions #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This issue has been resolved in version 1.3.55 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
This somehow came with a significant performance degrading in |
wkillerud
commented
Aug 8, 2024
Comment on lines
+33
to
+34
| this._writeDelayResolve = (a = -1) => a; | ||
| this._writeDelayChunks = (a = -1) => a; |
There was a problem hiding this comment.
This, maybe? Here we start returning the parameter instead of -1 by default.
There was a problem hiding this comment.
Yeah, this seems to be it. When I go back to always returning -1 here things seem to go back to normal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set up shared dev dependency config as well. Add minimum viable typing via JSDoc.