Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make healthcheck logging less verbose by default #433

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

wkillerud
Copy link
Contributor

Open for discussing this. Another option is of course to increase the loglevel to WARN if you think this is too verbose.

@leftieFriele
Copy link

We could re-write this to collect all errors in one and then have those errors be logged without the throwing going on.

const errors = [];
        try {
            await this._write();
        } catch (error) {
           errors.push({ message: 'Sink health check errored during write', error });
        }
        if (errors.length > 0) {
                logger.error(errors.join(''));
        }

Or something like that.

Then again we could also simplify these health checks a bit, as I feel they're are a bit too involved.
I would say one test which verifies that "The Sink is configured correctly and responds" would be sufficient here.

@wkillerud wkillerud merged commit 73a3a39 into main Aug 9, 2024
4 checks passed
@wkillerud wkillerud deleted the healthcheck-loglevel branch August 9, 2024 07:23
github-actions bot pushed a commit that referenced this pull request Aug 9, 2024
## [1.3.57](v1.3.56...v1.3.57) (2024-08-09)

### Bug Fixes

* make healthcheck logging less verbose by default ([#433](#433)) ([73a3a39](73a3a39))
Copy link

github-actions bot commented Aug 9, 2024

🎉 This issue has been resolved in version 1.3.57 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants