Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: init all context advice if root proto miss #139

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Conversation

killagu
Copy link
Contributor

@killagu killagu commented Aug 14, 2023

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 96.96% and project coverage change: +0.06% 🎉

Comparison is base (40d6627) 93.69% compared to head (067869b) 93.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage   93.69%   93.76%   +0.06%     
==========================================
  Files         226      227       +1     
  Lines        4697     4729      +32     
  Branches      505      509       +4     
==========================================
+ Hits         4401     4434      +33     
+ Misses        296      295       -1     
Files Changed Coverage Δ
plugin/aop/lib/AopContextHook.ts 96.15% <96.15%> (ø)
core/aop-runtime/src/LoadUnitAopHook.ts 100.00% <100.00%> (ø)
plugin/aop/app.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@killagu killagu added this pull request to the merge queue Aug 14, 2023
Merged via the queue into master with commit 0602ea8 Aug 14, 2023
17 checks passed
@killagu killagu deleted the fix/advice_egg branch August 14, 2023 03:42
@xuemengfei
Copy link

Cannot find module './lib/AopContextHook'

@killagu https://www.npmjs.com/package/@eggjs/tegg-aop-plugin?activeTab=code

image

@killagu
Copy link
Contributor Author

killagu commented Aug 14, 2023

Sorry. Fixed by #140.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants