Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure ContextInitiator be called after ctx ready #138

Merged
merged 1 commit into from
Aug 11, 2023
Merged

fix: ensure ContextInitiator be called after ctx ready #138

merged 1 commit into from
Aug 11, 2023

Conversation

killagu
Copy link
Contributor

@killagu killagu commented Aug 11, 2023

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@killagu killagu force-pushed the fix/call_module_in_middleware branch from 45209c5 to 36c3bd0 Compare August 11, 2023 08:37
@codecov
Copy link

codecov bot commented Aug 11, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f733441) 93.69% compared to head (36c3bd0) 93.69%.

❗ Current head 36c3bd0 differs from pull request most recent head ff1fc89. Consider uploading reports for the commit ff1fc89 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   93.69%   93.69%           
=======================================
  Files         226      226           
  Lines        4693     4697    +4     
  Branches      478      505   +27     
=======================================
+ Hits         4397     4401    +4     
  Misses        296      296
Files Changed Coverage Δ
plugin/tegg/lib/EggContextCompatibleHook.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fengmk2
fengmk2 approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@killagu killagu force-pushed the fix/call_module_in_middleware branch from 36c3bd0 to ff1fc89 Compare August 11, 2023 08:48
@killagu killagu added this pull request to the merge queue Aug 11, 2023
Merged via the queue into master with commit 79e16da Aug 11, 2023
14 checks passed
@killagu killagu deleted the fix/call_module_in_middleware branch August 11, 2023 08:50
@killagu
Copy link
Contributor Author

killagu commented Aug 11, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengmk2 fengmk2 fengmk2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@killagu @fengmk2