Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 事务注解增加数据源选项 #135

Merged
merged 1 commit into from
Jul 25, 2023
Merged

feat: 事务注解增加数据源选项 #135

merged 1 commit into from
Jul 25, 2023

Conversation

qile222
Copy link
Contributor

@qile222 qile222 commented Jul 24, 2023

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@codecov
Copy link

codecov bot commented Jul 24, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (550c9af) 93.51% compared to head (9e6a6a2) 93.51%.

❗ Current head 9e6a6a2 differs from pull request most recent head b20ad56. Consider uploading reports for the commit b20ad56 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #135   +/-   ##
=======================================
  Coverage   93.51%   93.51%           
=======================================
  Files         223      223           
  Lines        4659     4660    +1     
  Branches      473      474    +1     
=======================================
+ Hits         4357     4358    +1     
  Misses        302      302
Impacted Files Coverage Δ
core/transaction-decorator/src/Common.ts 100.00% <ø> (ø)
...ansaction-decorator/src/decorator/Transactional.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@qile222
feat: 事务注解增加数据源选项
b20ad56 
feat: 事务注解增加数据源选项

feat: 事务注解增加数据源选项
killagu
killagu approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killagu killagu added this pull request to the merge queue Jul 25, 2023
Merged via the queue into eggjs:master with commit c33b3b5 Jul 25, 2023
17 checks passed
@killagu
Copy link
Contributor

killagu commented Jul 25, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killagu killagu killagu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qile222 @killagu