feat: set plugin module optional false if be enabled as a plugin (#190)

<!--
Thank you for your pull request. Please review below requirements.
Bug fixes and new features should include tests and possibly benchmarks.
Contributors guide:
https://github.com/eggjs/egg/blob/master/CONTRIBUTING.md

感谢您贡献代码。请确认下列 checklist 的完成情况。
Bug 修复和新功能必须包含测试，必要时请附上性能测试。
Contributors guide:
https://github.com/eggjs/egg/blob/master/CONTRIBUTING.md
-->

##### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to
[x]. -->

- [ ] `npm test` passes
- [ ] tests and/or benchmarks are included
- [ ] documentation is changed or added
- [ ] commit message follows commit guidelines

##### Affected core subsystem(s)
<!-- Provide affected core subsystem(s). -->


##### Description of change
<!-- Provide a description of the change below this comment. -->

<!--
- any feature?
- close https://github.com/eggjs/egg/ISSUE_URL
-->

plugin/tegg/lib/EggModuleLoader.ts

@@ -18,6 +18,13 @@ export class EggModuleLoader {
 
   private buildAppGraph(loaderCache: Map<string, Loader>) {
     const appGraph = new AppGraph();
+    for (const plugin of Object.values(this.app.plugins)) {
+      if (!plugin.enable) continue;
+      const modulePlugin = this.app.moduleReferences.find(t => t.path === plugin.path);
+      if (modulePlugin) {
+        modulePlugin.optional = false;
+      }
+    }
     for (const moduleConfig of this.app.moduleReferences) {
       const modulePath = moduleConfig.path;
       const moduleNode = new ModuleNode(moduleConfig);

plugin/tegg/test/OptionalPluginModule.test.ts

@@ -0,0 +1,36 @@
+import mm from 'egg-mock';
+import assert from 'assert';
+import path from 'path';
+import { UsedProto } from './fixtures/apps/plugin-module/node_modules/foo-plugin/Used';
+
+describe('test/OptionalPluginModule.test.ts', () => {
+  let app;
+  const fixtureDir = path.join(__dirname, 'fixtures/apps/plugin-module');
+
+  after(async () => {
+    await app.close();
+  });
+
+  afterEach(() => {
+    mm.restore();
+  });
+
+  before(async () => {
+    mm(process.env, 'EGG_TYPESCRIPT', true);
+    mm(process, 'cwd', () => {
+      return path.join(__dirname, '..');
+    });
+    app = mm.app({
+      baseDir: fixtureDir,
+      framework: require.resolve('egg'),
+    });
+    await app.ready();
+  });
+
+  it('should work', async () => {
+    await app.mockModuleContextScope(async ctx => {
+      const usedProto = await ctx.getEggObject(UsedProto);
+      assert(usedProto);
+    });
+  });
+});

plugin/tegg/test/fixtures/apps/plugin-module/config/config.default.js

@@ -0,0 +1,20 @@
+'use strict';
+
+const path = require('path');
+
+module.exports = function(appInfo) {
+  const config = {
+    keys: 'test key',
+    customLogger: {
+      xxLogger: {
+        file: path.join(appInfo.root, 'logs/xx.log'),
+      },
+    },
+    security: {
+      csrf: {
+        ignoreJSON: false,
+      }
+    },
+  };
+  return config;
+};

plugin/tegg/test/fixtures/apps/plugin-module/config/plugin.js

@@ -0,0 +1,18 @@
+'use strict';
+
+exports.tracer = {
+  package: 'egg-tracer',
+  enable: true,
+};
+
+exports.teggConfig = {
+  package: '@eggjs/tegg-config',
+  enable: true,
+};
+
+exports.eggFooPlugin = {
+  package: 'foo-plugin',
+  enable: true,
+};
+
+exports.watcher = false;

plugin/tegg/test/fixtures/apps/plugin-module/package.json

@@ -0,0 +1,6 @@
+{
+  "name": "egg-app",
+  "egg": {
+    "framework": "foo"
+  }
+}