Custom authority connector for Airtable #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified Airtable version of connector to enable custom URI in TEI Publisher
wolfgangmm
reviewed
Jun 20, 2022
| return ''; | ||
| } | ||
|
|
||
| export class Airtable extends Registry { |
There was a problem hiding this comment.
Shouldn't this class be named differently to avoid conflicts with the existing Airtable class? The tests fail due to this.
There was a problem hiding this comment.
I think we could streamline this by making the ID to use configurable. I'll make a proposal tomorrow...
There was a problem hiding this comment.
So I would propose the following: instead of creating a new connector, change the existing airtable connector to accept an additional attribute use-as-key in the config element. Right now I can't test this myself, but I'd say the required changes would be:
- in line 35 add another variable
this.idField = configElem.getAttribute('use-as-key'); - in line 101, change the
idproperty toid: this.idField ? record.get(this.idField) : record.id, - in line 120, we also need to take into account that the
filterByFormulaexpression needs to be different, so replace withfilterByFormula: this.idField ?${this.idField}='${key}':RECORD_ID()='${key}'` - then again in line 160 change the
idproperty:id: this.idField ? record.get(this.idField) : record.id,
Could you try this and report if it works?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified Airtable version of connector to enable custom URI in TEI Publisher