Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DEPR USE-JWT-COOKIE header #312

Merged
merged 1 commit into from
Aug 29, 2024
Merged

feat: DEPR USE-JWT-COOKIE header #312

merged 1 commit into from
Aug 29, 2024

Conversation

robrap
Copy link
Contributor

@robrap robrap commented Aug 28, 2024

his repo is no longer using USE-JWT-COOKIE header, since it has the required edx-drf-extensions>10.2.0, where it was fully removed.

This is final clean-up for this repo.

See "[DEPR]: USE-JWT-COOKIE header" for more details:

JIRA: Link to JIRA ticket

Description: Describe in a couple of sentences what this PR adds

Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.

Dependencies: dependencies on other outstanding PRs, issues, etc.

Installation instructions: List any non-trivial installation
instructions.

Testing instructions:

  1. Open page A
  2. Do thing B
  3. Expect C to happen
  4. If D happened instead - check failed.

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Delete working branch (if not needed anymore)

his repo is no longer using USE-JWT-COOKIE header,
since it has the required edx-drf-extensions>10.2.0,
where it was fully removed.

This is final clean-up for this repo.

See "[DEPR]: USE-JWT-COOKIE header" for more details:
- openedx/edx-drf-extensions#371
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Member

@timmc-edx timmc-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Mis-paste in commit/PR description (missing initial "T")

@robrap robrap merged commit 077e7fc into main Aug 29, 2024
5 checks passed
@robrap robrap deleted the robrap/DEPR-USE-JWT-COOKIE branch August 29, 2024 14:31
robrap added a commit that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants