feat: Collect output from all attempts of workflows; full JSON output #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a reworking of `get_action_errors.py` with the following goals: - Retrieve all attempts of a workflow, not just the last one. This is important for collection of transient errors since people will usually re-run their workflows when there is a failure unrelated to their code. - Tolerate interruptions of the script due to timeouts, rate-limiting, and networking issues. On re-run, workflow runs that have been fully fetched are skipped. - Record the full JSON for workflow attempts, checks, and annotations so that we can do more in-depth queries if needed. The script no longer produces a CSV, but it's still straightforward to query how often we're seeing a particular error.
timmc-edx
commented
Jan 31, 2024
|
|
||
| # Get the checks associated with this workflow run -- this | ||
| # includes output title, summary, and text. | ||
| for check_run in self._github_get(attempt['check_suite_url'] + '/check-runs').json()['check_runs']: |
There was a problem hiding this comment.
Author's note: This... isn't actually working. Different attempts on the same workflow are getting the same check runs.
There was a problem hiding this comment.
Asking about this here: https://github.com/orgs/community/discussions/103026
timmc-edx
commented
Feb 2, 2024
| # Once all attempts have been logged, write out a marker file | ||
| # that indicates this workflow has been completely downloaded | ||
| # and can be skipped in the future. | ||
| self._write_json(self.download_marker_data, download_marker) |
There was a problem hiding this comment.
Author's note: Consider writing the latest attempt count here, and checking it at the start of the method. A workflow could have had new attempts since the last execution of the script. Somewhat of an edge case, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reworking of
get_action_errors.pywith the following goals:The script no longer produces a CSV, but it's still straightforward to query how often we're seeing a particular error.
Merge checklist:
Check off if complete or not applicable: