Delete recordings w/ only bots or that are silent #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of uploading recordings of meetings that only had bots (e.g. the Otter.ai notetaker) or that are completely silent (nobody turned on their mic; probably only one person showed up), delete those recordings from Zoom (we still want to save space) and do not upload them to YouTube (nobody needs to see empty meetings). This also includes some light refactor of a few things and better error handling around Zoom API calls.
Mr0grog
added a commit
that referenced
this pull request
Aug 29, 2024
I used ffmpeg to detect silent videos in #73, but to make sure it’s actually installed in CI. This fixes the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed after we fixed this script that it frequently uploads empty/silent recordings of meetings nobody attended (usually because the only attendee was a bot, or one person showed up but nobody else did):
Instead of uploading those recordings, the changes here skip them. In addition:
DELETE_AFTER_UPLOADINGis set.This also makes some other minor refactors to handle errors better and clean up the code slightly.