Skip to content

Commit

Permalink
test: Test with singer-sdk prerelease
Browse files Browse the repository at this point in the history
  • Loading branch information
edgarrmondragon committed Feb 23, 2024
1 parent f140e5c commit ec859b7
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 20 deletions.
8 changes: 4 additions & 4 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,12 @@ keywords = ["ELT", "Jotform"]
python = ">=3.8"
colorama = "==0.4.*"
requests-cache = "==1.2.*"
singer-sdk = "==0.35.*"
singer-sdk = { version = "==0.36.0rc1", allow-prereleases = true }
structlog = "==24.1.*"

[tool.poetry.group.dev.dependencies]
pytest = "==8.*"
singer-sdk = { version = "==0.35.*", extras = ["testing"] }
singer-sdk = { version = "==0.36.0rc1", allow-prereleases = true, extras = ["testing"] }

[tool.poetry.scripts]
# CLI declaration
Expand Down
14 changes: 0 additions & 14 deletions tap_jotform/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,20 +14,6 @@
class JotformPaginator(BaseOffsetPaginator):
"""Jotform pagination class."""

def has_more(self, response: requests.Response) -> bool:
"""Return True if there are more pages to fetch.
Args:
response: The response object from the last request.
Returns:
True if there are more pages to fetch, False otherwise.
"""
result_set = response.json()["resultSet"]
count = int(result_set["count"])

return count == self._page_size


class JotformStream(RESTStream):
"""Jotform stream class."""
Expand Down

0 comments on commit ec859b7

Please sign in to comment.