Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ssl engine #403

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add ssl engine #403

wants to merge 1 commit into from

Conversation

shawshank119
Copy link

add ssl engine mode for load private key.

@fpagliughi
Copy link
Contributor

Hey, thanks for the PR, and sorry for the slow response.

Obviously this is blocked by the PR to the Paho C library:
eclipse/paho.mqtt.c#1247

Also, the changes to the ssl_options constructor parameter order would technically be a breaking change. It would be better to add the parameters with default values at the end of the parameter list. That wouldn't break existing code. But, obviously, the C update needs to be addressed first.

@fpagliughi fpagliughi added the upstream Problem with upstream library label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
upstream Problem with upstream library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shawshank119 @fpagliughi