Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of up-streamer-rust - UTransport Non-thread-safe version #7

Conversation

PLeVasseur
Copy link
Contributor

Hey there 👋

Based on @stevenhartley's stellar design, I reworked the in-progress first PR I had.

Looking for any feedback you may have 🙂

I suppose this would be to address #3

@PLeVasseur
Copy link
Contributor Author

Paging @sophokles73, @AnotherDaniel, @evshary for your kind guidance 🤗

@PLeVasseur
Copy link
Contributor Author

Realizing I forgot to swap out the println!() for log crate logs. Will need to do this.

@PLeVasseur
Copy link
Contributor Author

Realizing I forgot to swap out the println!() for log crate logs. Will need to do this.

Finished with this now

CONTRIBUTING.md Show resolved Hide resolved
Comment on lines +24 to +26
authors = [
"Pete LeVasseur <[email protected]>",
]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to become an exhaustive list of contributors? The Eclipse Foundation considers maintaining such lists obsolete because everybody can derive it from the Git log. This might have some value for pointing out a prime contact for the project, though, if that is what you had intended to do :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. I wonder -- should we have one or two primary points of contact for each of the projects that we put in here?

I get what you mean about keeping track of all contributors to be not needed.

]

[workspace.package]
rust-version = "1.66.1"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this aligned (and verified) with all of your upstream dependencies?

Copy link
Contributor Author

@PLeVasseur PLeVasseur Mar 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can check.

What's the best way to do this? Checking dependencies' Cargo.toml manually?

Cargo.toml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
up-streamer/src/utransport_builder.rs Outdated Show resolved Hide resolved
… we receive it over the UTransport and then put in an Arc<UMessage> so when we're passing these around between channels it's only as big as a fat pointer, not as big as the entire UMessage.
up-streamer/src/route.rs Outdated Show resolved Hide resolved
@PLeVasseur PLeVasseur force-pushed the feature/initial-pluggable-ustreamer branch from 9e8bbb7 to cf2f9ab Compare April 1, 2024 20:03
@PLeVasseur PLeVasseur changed the title Initial implementation of up-streamer-rust Initial implementation of up-streamer-rust - Non-thread-safe version Apr 5, 2024
@PLeVasseur PLeVasseur changed the title Initial implementation of up-streamer-rust - Non-thread-safe version Initial implementation of up-streamer-rust - UTransport Non-thread-safe version Apr 5, 2024
@PLeVasseur PLeVasseur marked this pull request as draft April 5, 2024 14:31
@PLeVasseur
Copy link
Contributor Author

Closing in favor of #8

Going to move unresolved comments over

@PLeVasseur PLeVasseur closed this Apr 5, 2024
@PLeVasseur PLeVasseur deleted the feature/initial-pluggable-ustreamer branch August 13, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants