Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(project_obligations): Add view for license obligations #244

Merged
merged 1 commit into from
May 30, 2024

Conversation

deo002
Copy link
Contributor

@deo002 deo002 commented Apr 2, 2024

No description provided.

@deo002 deo002 force-pushed the obligations branch 2 times, most recently from 1f7806d to 47b54d2 Compare April 2, 2024 08:51
@deo002
Copy link
Contributor Author

deo002 commented Apr 11, 2024

Will resolve this soon

@heliocastro
Copy link
Contributor

@deo002 How the status of this PR ? Did @hoangnt2 questions solved ?

@deo002
Copy link
Contributor Author

deo002 commented May 15, 2024

@deo002 How the status of this PR ? Did @hoangnt2 questions solved ?

Sorry for the delay on this. Some backend changes are required. Once they are done, I'll push the corresponding changes for frontend.

@heliocastro
Copy link
Contributor

@deo002 Just remember to tag WIP at least that we know that is not ready. I tagged this time.
Maybe when tag this things, we should add a reference on why we need wait for some parallel work.

@deo002
Copy link
Contributor Author

deo002 commented May 15, 2024

@deo002 Just remember to tag WIP at least that we know that is not ready. I tagged this time. Maybe when tag this things, we should add a reference on why we need wait for some parallel work.

Yes, I'll make sure to add tags next time.

@deo002 deo002 force-pushed the obligations branch 2 times, most recently from 57749a2 to 754c739 Compare May 28, 2024 06:18
@deo002
Copy link
Contributor Author

deo002 commented May 28, 2024

Comments have been addressed @hoangnt2 . Sorry for the delay. Unfortunately, I do not have the required rights to remove the WIP tag.

@hoangnt2 hoangnt2 removed the WIP label May 28, 2024
@heliocastro heliocastro requested a review from hoangnt2 May 28, 2024 18:25
heliocastro
heliocastro previously approved these changes May 28, 2024
Copy link
Contributor

@heliocastro heliocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heliocastro heliocastro self-requested a review May 28, 2024 18:27
@deo002
Copy link
Contributor Author

deo002 commented May 29, 2024

Done @hoangnt2

Copy link
Contributor

@hoangnt2 hoangnt2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hoangnt2 hoangnt2 merged commit 77cf706 into eclipse-sw360:main May 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants