Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the remote maven listener a process in the launch #1706

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Mar 3, 2024

Currently m2e uses an additional socket connection to receive project events from the remote maven project. This is not visible to the user and requires some internal maps to maintain state.

This refactors this into a more generic event facility and make it visible as a Process in the debug view, this also has the advantage that the process itself can be used to maintain the state.

Copy link

github-actions bot commented Mar 3, 2024

Test Results

0 files   -   214  0 suites   - 214   0s ⏱️ - 22m 4s
0 tests  -   665  0 ✅  -   655  0 💤  - 10  0 ❌ ±0 
0 runs   - 1 330  0 ✅  - 1 308  0 💤  - 22  0 ❌ ±0 

Results for commit 7024d55. ± Comparison against base commit 112488c.

♻️ This comment has been updated with latest results.

@laeubi laeubi force-pushed the make_remote_listener_an_own_process branch 2 times, most recently from 8f8bb67 to 716fa0d Compare March 4, 2024 06:52
@laeubi laeubi marked this pull request as ready for review March 4, 2024 06:52
@laeubi laeubi force-pushed the make_remote_listener_an_own_process branch from 716fa0d to 4767cd5 Compare March 4, 2024 06:52
@laeubi laeubi changed the title Make the remove maven listener a process in the launch Make the remote maven listener a process in the launch Mar 4, 2024
@laeubi laeubi force-pushed the make_remote_listener_an_own_process branch from 4767cd5 to 7c19799 Compare March 4, 2024 07:44
Currently m2e uses an additional socket connection to receive project
events from the remote maven project. This is not visible to the user
and requires some internal maps to maintain state.

This refactors this into a more generic event facility and make it
visible as a Process in the debug view, this also has the advantage that
the process itself can be used to maintain the state.
@laeubi laeubi force-pushed the make_remote_listener_an_own_process branch from 7c19799 to 7024d55 Compare March 4, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant