Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider the settings files location in project configuration #1675

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Feb 14, 2024

Currently the settings files are not considered when grouping projects by there project configuration.

As the settings files can have an impact they should be considered when grouping projects.

This is part of

after further investigation I'm not sure if it is required or useful at all and if not

is actually enough, because if the multi module basedir is the same the settings needs also be the same, the same is true as well for profiles and user properties, so the main question would be if there are cases where the settings are defined differently other than maven.config or m2e preferences.

Currently the settings files are not considered when grouping projects
by there project configuration.

As the settings files can have an impact they should be considered when
grouping projects.

Signed-off-by: Christoph Läubrich <[email protected]>
Copy link

Test Results

  214 files  ±0    214 suites  ±0   20m 36s ⏱️ -23s
  664 tests ±0    653 ✅  - 1  10 💤 ±0  1 ❌ +1 
1 328 runs  ±0  1 305 ✅  - 1  22 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 7125782. ± Comparison against base commit 6880fa1.

@HannesWell
Copy link
Contributor

Does this contain parts not already submitted in other PRs or can this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants