Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

classpathentry should respect pom resource excludes/includes #1625

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

qxo
Copy link

@qxo qxo commented Dec 17, 2023

so we build project on eclipse without org.eclipse.m2e.core.maven2Builder

Copy link

github-actions bot commented Feb 3, 2024

Test Results

  214 files  ±0    214 suites  ±0   15m 53s ⏱️ - 6m 7s
  665 tests ±0    653 ✅  - 2  10 💤 ±0  2 ❌ +2 
1 330 runs  ±0  1 304 ✅  - 4  22 💤 ±0  4 ❌ +4 

For more details on these failures, see this check.

Results for commit 55afb02. ± Comparison against base commit 369b34f.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @qxo, thank you for providing this PR.
In general this change looks reasonable, but we have to work through a few things until it can be considered for submission.

First of all, you have to sign the Eclipse Contributor Agreement, otherwise we are not allowed to accept your change.

Second please add a test-case to org.eclipse.m2e.jdt.tests in order to demonstrate the missing feature and to ensure it will continue to work in the future.

About the change itself, please see the remarks below.

@qxo qxo force-pushed the feat-classpathentry-excluding branch from 3a7b9c5 to 5583529 Compare February 17, 2024 15:15
excludes/includes,:
so we build project on eclipse without org.eclipse.m2e.core.maven2Builder
@qxo qxo force-pushed the feat-classpathentry-excluding branch from 1cb6b9e to a3a9641 Compare February 18, 2024 05:00
@qxo qxo force-pushed the feat-classpathentry-excluding branch from 55afb02 to 40a80f4 Compare March 16, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants