This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Refactor Welcome plugin #1155
Draft
Refactor Welcome plugin #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vitaliy Gulyy <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1155 +/- ##
==========================================
- Coverage 32.78% 32.61% -0.18%
==========================================
Files 290 293 +3
Lines 9885 9941 +56
Branches 1457 1469 +12
==========================================
+ Hits 3241 3242 +1
- Misses 6641 6696 +55
Partials 3 3
Continue to review full report at Codecov.
|
|
❌ E2E Happy path tests failed ❗
See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
zWingz
reviewed
Aug 6, 2021
|
|
||
| export async function isMultiroot(): Promise<boolean> { | ||
| const devfile = await che.devfile.get(); | ||
| return devfile.metadata?.attributes?.multiRoot !== 'off'; |
There was a problem hiding this comment.
I see Multi-root is the only mode in Che-Theia in #1191 ...
| "name": "@eclipse-che/ports-plugin", | ||
| "publisher": "Eclipse Che", | ||
| "name": "ports-plugin", | ||
| "publisher": "@eclipse-che", |
There was a problem hiding this comment.
Does It is a breaking change for the plugin which provided by other developer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vitaliy Gulyy [email protected]
What does this PR do?
Improves Welcome plugin.
Adds checkbox to the welcome page to avoid opening the welcome page at the workspace stratup.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.
Happy Path Channel
HAPPY_PATH_CHANNEL=next