Collab Highlight #141
Open
Collab Highlight #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Setup Sidney's commit for collaboration - Base collaboration works without highlight
Added collab highlight implementation to Sidney's clean collaboration pr/46
- Move div creation in a class function
- Eliminate redundant: - Creation of highlight divs - Reassignment of constants variables
Reflects the current data structure
Removes highlight when peers leave. E.g. exit browser without deselecting the text.
Collab Highlight was originally built on an older commit. When collab highlight code was copied to commit cb48ab, some code were altered as a side-effect. In this commit, commit cb48ab (base) and 5e6c9d1 (head) was diff-ed to find and restore altered code. Restoring code from 1. commit cb48ab8 Author: libing wang <[email protected]> Date: Thu Jun 22 15:04:33 2017 -0400 Subj: Bug 514792 - AnnotationStyler to merge html and DOM node style in com... Side-effect: Around line `create: function(_parent, div, drawing) {`, all instance of 'drawing' was removed In this commit: restored 'drawing' 2. commit c81fb19 Author: Sidney <[email protected]> Date: Thu Jun 15 16:53:04 2017 -0400 Subj: cleaned 50% garbage code Side-effect: '/file/' came back. In this commit: removed '/file/'
Collab highlight width was inconsistent across different browsers. The width would vary on different browsers as peers select long texts on the same line. This is due to the use of a calculated constant in the code rather than using environment variables that we were unaware of at the time. Thanks to Silenio, we found a variable to fixes this issue.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked commits