Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

#532 Arrays within Arrays not parsed properly when converting JSON to… #533

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gcameo
Copy link

@gcameo gcameo commented Jun 22, 2018

… DynamicObject

@jponge
Copy link
Contributor

jponge commented Jun 26, 2018

On the checks failing:

  1. Travis and AppVeyor failing indicate that the tests suite doesn't pass.
  2. IP Validation: see https://wiki.eclipse.org/ECA

@jponge jponge requested a review from k33g June 26, 2018 17:22
@jponge
Copy link
Contributor

jponge commented Aug 28, 2020

@k33g old PR but still relevant, fancy a review?

Copy link
Contributor

@k33g k33g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jponge I get an error when compiling:

[error] In Golo module: json.golo
[error]   Undeclared reference `item` in function `__$$_golo$compiler$sugar_closure_10` at {line=163, column=27}.
[error]   Undeclared reference `item` in function `__$$_golo$compiler$sugar_closure_10` at {line=165, column=10}.

@@ -160,6 +160,18 @@ local function toDynamicObjectFromJSONObject = |obj| {
dyno: get(level): append(subDyno)
}
})
} else if isJSONArray(item) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, but it seems that item is never declared

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants