Update role for network url #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ployment name and not tezos_network
|
Fixed the regex check for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update will allow the role to take a URL value for the tezos_network variable. If the value of
tezos_networkis a URL then a new variable is set callednetwork_name. The value ofnetwork_namewill be the string after the last/in the URL. This new variable will be used for naming directories, configuring thenode_rpc_urlvariable, and naming the docker container. The default valuenode_rpc_urlis no longer set in thedefaults.ymlfile but is now set in the playbook at runtime. The value oftezos_network(In this case a URL) will be used to start the docker container with the--networkflag.