Skip to content
This repository has been archived by the owner on Aug 25, 2022. It is now read-only.

GH-63: Paginating the term list page. #64

Open
wants to merge 2 commits into
base: 8.x-1.x
Choose a base branch
from

Conversation

upchuk
Copy link
Contributor

@upchuk upchuk commented Aug 22, 2018

Fixes GH-63.

Copy link
Contributor

@claudiu-cristea claudiu-cristea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we test the pagination?

@upchuk
Copy link
Contributor Author

upchuk commented Aug 22, 2018

@claudiu-cristea Well, normally this is core behaviour. Before the entity list builder was altered and removed the pagination. I simply kind of re-added it back with the small addition of the intended override (restricting the terms to the current vocabulary). So not sure if tests are warranted for this?

@claudiu-cristea
Copy link
Contributor

claudiu-cristea commented Aug 22, 2018

@upchuk OK, will check in detail when I'll QA the ticket

@claudiu-cristea claudiu-cristea dismissed their stale review August 22, 2018 14:18

Have to reckeck

@upchuk
Copy link
Contributor Author

upchuk commented Aug 24, 2018

@claudiu-cristea This might be a bit more complicated than it seems. Core apparently overrides the overview route to dump in a form which loads a tree and renders it in a draggable table. However, I think with a huge vocabulary that would break the browser as well :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants