Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(unordered-list): Setting list style position to outside also in print - FRONT-4602 #3633

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

planctus
Copy link
Contributor

Copy link

github-actions bot commented Sep 17, 2024

@github-actions github-actions bot temporarily deployed to pull request September 17, 2024 07:40 Inactive
@planctus planctus marked this pull request as ready for review September 17, 2024 08:06
@github-actions github-actions bot temporarily deployed to pull request September 17, 2024 08:14 Inactive
Copy link
Contributor

@emeryro emeryro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be seen in another PR, but we have a very different display for list if the "default" css is not there. I guess that we are missing things in the print css itself
image

@planctus
Copy link
Contributor Author

but i'm not really sure about what to do here, the fact that there is a difference with or without the default css i'd say it's normal, the default css duplicates all the rules in the standard css for the ecl selectors, so it's like saying that there is a difference between the main style and the print style.
I have adapted some obvious things, like the markers and checked more or less the consistency of all the variants in unordered and ordered lists. There is less padding in print, a smaller line-height, but that seems to be coherent with the print styles.

@github-actions github-actions bot temporarily deployed to pull request September 18, 2024 11:58 Inactive
@emeryro emeryro merged commit 1b8db25 into v4-dev Sep 23, 2024
7 checks passed
@emeryro emeryro deleted the FRONT-4602-list-print-fix branch September 23, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants