feat(video): Adding support for muted, autoplay and loop - Media container adding autoplay video option - FRONT-4600 #3603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emeryro
requested changes
Sep 5, 2024
| extra_classes: video_classes, | ||
| extra_attributes: video_attributes, | ||
| extra_attributes: video.attributes|default([])|merge([{ name: 'data-ecl-banner-video' }]), |
There was a problem hiding this comment.
shouldn't it be _video.extra_attributes?
| ...args, | ||
| autoplay: false, | ||
| muted: false, | ||
| loop: false, |
There was a problem hiding this comment.
The idea of COMM here is to have a single control that would toggle the different video options: autoplay, muted, loop and controls.
We should keep the parameter in the video, as you have them, but just expose one control in the media container (either we have a normal video player, or we have an autoplay video like on the banner)
planctus
added
process: business approval needed
and removed
process: changes requested
labels
…y into FRONT-4600-video-autoplay
planctus
changed the title
planctus
changed the title
…y into FRONT-4600-video-autoplay
planctus
added
process: review needed
and removed
process: business approval needed
labels
emeryro
changed the title
emeryro
approved these changes
Sep 17, 2024
emeryro
added
tag: markup changes
tag: data change
and removed
process: review needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.