Skip to content

Commit

Permalink
fix rtl (#3649)
Browse files Browse the repository at this point in the history
  • Loading branch information
emeryro committed Sep 27, 2024
1 parent 5ef50de commit ddd228a
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 3 deletions.
5 changes: 4 additions & 1 deletion src/implementations/vanilla/components/modal/modal.scss
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,10 @@ $overflow-height: 2rem;
}

.ecl-modal__close {
margin: map.get($modal, 'close-margin');
margin-bottom: 0;
margin-inline-end: map.get($modal, 'close', 'margin-end');
margin-inline-start: 0;
margin-top: map.get($modal, 'close', 'margin-top');

.ecl-button__icon {
margin: 0;
Expand Down
5 changes: 4 additions & 1 deletion src/themes/ec/variables/_modal.scss
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@ $modal: (
padding-mobile: var(--s-3xl) var(--s-3xl) var(--s-xl) var(--s-3xl),
padding-desktop: var(--s-3xl) var(--s-3xl) var(--s-xl) var(--s-3xl),
),
close-margin: calc(-1 * var(--s-xl)) calc(-1 * var(--s-xl)) 0 0,
close: (
margin-top: calc(-1 * var(--s-xl)),
margin-end: calc(-1 * var(--s-xl)),
),
body: (
padding-mobile: 0 var(--s-3xl) var(--s-xl) var(--s-3xl),
padding-desktop: 0 var(--s-3xl) var(--s-xl) var(--s-3xl),
Expand Down
5 changes: 4 additions & 1 deletion src/themes/eu/variables/_modal.scss
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@ $modal: (
padding-mobile: var(--s-l) var(--s-l) var(--s-m),
padding-desktop: var(--s-l) var(--s-l) var(--s-m),
),
close-margin: calc(-1 * var(--s-s)) calc(-1 * var(--s-s)) 0 0,
close: (
margin-top: calc(-1 * var(--s-s)),
margin-end: calc(-1 * var(--s-s)),
),
body: (
padding-mobile: 0 var(--s-l) var(--s-m) var(--s-l),
padding-desktop: 0 var(--s-l) var(--s-m) var(--s-l),
Expand Down

1 comment on commit ddd228a

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.